Re: [libvirt] [PATCH 11/30] storagefile: Rename qcow2GetExtensions 'format' argument

2019-10-11 Thread Cole Robinson
On 10/9/19 5:14 PM, Daniel Henrique Barboza wrote: On 10/7/19 6:49 PM, Cole Robinson wrote: To backingFormat, which makes it more clear. Move it to the end of the argument list which will scale nicer with future patches Signed-off-by: Cole Robinson --- This really makes it clearer. I was g

Re: [libvirt] [PATCH 11/30] storagefile: Rename qcow2GetExtensions 'format' argument

2019-10-09 Thread Daniel Henrique Barboza
On 10/7/19 6:49 PM, Cole Robinson wrote: To backingFormat, which makes it more clear. Move it to the end of the argument list which will scale nicer with future patches Signed-off-by: Cole Robinson --- This really makes it clearer. I was getting confused about whether 'format' was referrin

[libvirt] [PATCH 11/30] storagefile: Rename qcow2GetExtensions 'format' argument

2019-10-07 Thread Cole Robinson
To backingFormat, which makes it more clear. Move it to the end of the argument list which will scale nicer with future patches Signed-off-by: Cole Robinson --- src/util/virstoragefile.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virstoragefile.c b/