Re: [libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

2015-10-14 Thread Peter Krempa
On Tue, Oct 13, 2015 at 16:58:53 -0400, John Ferlan wrote: > On 10/13/2015 08:39 AM, Peter Krempa wrote: > > On Fri, Oct 09, 2015 at 09:34:11 -0400, John Ferlan wrote: ... > > This comment should document the required behavior at the point where we > > define the callback structure. Otherwise

Re: [libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

2015-10-13 Thread Peter Krempa
On Fri, Oct 09, 2015 at 09:34:11 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1233003 > > Commit id 'fdda3760' only managed a symptom where it was possible to > create a file in a pool without libvirt's knowledge, so it was reverted. > > The real fix is to have all the

Re: [libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

2015-10-13 Thread John Ferlan
On 10/13/2015 08:39 AM, Peter Krempa wrote: > On Fri, Oct 09, 2015 at 09:34:11 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1233003 >> >> Commit id 'fdda3760' only managed a symptom where it was possible to >> create a file in a pool without libvirt's knowledge, so it

[libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

2015-10-09 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1233003 Commit id 'fdda3760' only managed a symptom where it was possible to create a file in a pool without libvirt's knowledge, so it was reverted. The real fix is to have all the createVol API's which actually create a volume (disk, logical, zfs)