Re: [libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

2014-04-01 Thread Eric Blake
On 03/31/2014 09:56 AM, Eric Blake wrote: On 03/31/2014 02:56 AM, Peter Krempa wrote: On 03/29/14 23:20, Eric Blake wrote: Now that we have a common struct, it's time to start using it! Since external snapshots make a longer backing chain, it is only natural to use the same struct for the

Re: [libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

2014-03-31 Thread Peter Krempa
On 03/29/14 23:20, Eric Blake wrote: Now that we have a common struct, it's time to start using it! Since external snapshots make a longer backing chain, it is only natural to use the same struct for the file created by the snapshot as what we use for domain disks. *

Re: [libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

2014-03-31 Thread Eric Blake
On 03/31/2014 02:56 AM, Peter Krempa wrote: On 03/29/14 23:20, Eric Blake wrote: Now that we have a common struct, it's time to start using it! Since external snapshots make a longer backing chain, it is only natural to use the same struct for the file created by the snapshot as what we use

[libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

2014-03-29 Thread Eric Blake
Now that we have a common struct, it's time to start using it! Since external snapshots make a longer backing chain, it is only natural to use the same struct for the file created by the snapshot as what we use for domain disks. * src/conf/snapshot_conf.h (_virDomainSnapshotDiskDef): Use common