Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-22 Thread Laine Stump
On 12/20/2010 06:22 PM, Eric Blake wrote: On 12/20/2010 01:03 AM, Laine Stump wrote: 1) Don't attempt to immediately read the pidfile and store the pid in memory. Instead, just read the pidfile later when we want to kill radvd. (This could still lead to a race if networkStart and

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-22 Thread Laine Stump
On 12/20/2010 05:46 PM, Paweł Krześniak wrote: On Mon, Dec 20, 2010 at 09:03, Laine Stumpla...@laine.org wrote: There are two possible solutions for this: 1) Don't attempt to immediately read the pidfile and store the pid in memory. Instead, just read the pidfile later when we want to kill

[libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-20 Thread Laine Stump
Running an instance of the router advertisement daemon (radvd) allows guests using the virtual network to automatically acquire and IPv6 address and default route. Note that acquiring an address only works for networks with a prefix length of exactly 64 - radvd is still run in other circumstances,

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-20 Thread Paweł Krześniak
On Mon, Dec 20, 2010 at 09:03, Laine Stump la...@laine.org wrote: There are two possible solutions for this: 1) Don't attempt to immediately read the pidfile and store the pid in   memory. Instead, just read the pidfile later when we want to kill   radvd. (This could still lead to a race if

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-20 Thread Eric Blake
On 12/20/2010 01:03 AM, Laine Stump wrote: 1) Don't attempt to immediately read the pidfile and store the pid in memory. Instead, just read the pidfile later when we want to kill radvd. (This could still lead to a race if networkStart and networkDestroy were called in tight sequence