Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-29 Thread Andrea Bolognani
On Mon, 2019-07-29 at 12:39 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2019 at 05:46:38PM +0200, Andrea Bolognani wrote: > > On Fri, 2019-07-26 at 16:21 +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 26, 2019 at 05:19:56PM +0200, Andrea Bolognani wrote: > > > > [...] > > > > >

Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2019 at 05:46:38PM +0200, Andrea Bolognani wrote: > On Fri, 2019-07-26 at 16:21 +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 26, 2019 at 05:19:56PM +0200, Andrea Bolognani wrote: > > > [...] > > > > +REMOTE_DAEMON_LD_ADD += \ > > > > + ../gnulib/lib/libgnu.la \ > > > > +

Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-26 Thread Andrea Bolognani
On Fri, 2019-07-26 at 16:21 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2019 at 05:19:56PM +0200, Andrea Bolognani wrote: > > [...] > > > +REMOTE_DAEMON_LD_ADD += \ > > > + ../gnulib/lib/libgnu.la \ > > > + $(LIBSOCKET) \ > > > + $(NULL) > > > > As an aside, it looks like $(LIBSOCKET) is a

Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-26 Thread Daniel P . Berrangé
On Fri, Jul 26, 2019 at 05:19:56PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > > The same make variables will be useful for building both libvirtd and > > the split daemons, so refactor & rename variables to facilitate reuse. > > > > Automake

Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-26 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > The same make variables will be useful for building both libvirtd and > the split daemons, so refactor & rename variables to facilitate reuse. > > Automake gets annoyed if you define a variable ending LDFLAGS: > >

[libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd

2019-07-23 Thread Daniel P . Berrangé
The same make variables will be useful for building both libvirtd and the split daemons, so refactor & rename variables to facilitate reuse. Automake gets annoyed if you define a variable ending LDFLAGS: src/remote/Makefile.inc.am:53: warning: variable 'REMOTE_DAEMON_LDFLAGS' is defined but no