Re: [libvirt] [PATCH 14/21] qemu_hotplug: remove extra function in middle of DetachController call chain

2019-03-22 Thread Laine Stump
On 3/22/19 7:39 AM, Peter Krempa wrote: On Thu, Mar 21, 2019 at 18:28:54 -0400, Laine Stump wrote: qemuDomainDetachDeviceControllerLive() just checks if the controller type is SCSI, and then either returns failure, or calls qemuDomainDetachControllerDevice(). Instead, lets just check for type

Re: [libvirt] [PATCH 14/21] qemu_hotplug: remove extra function in middle of DetachController call chain

2019-03-22 Thread Peter Krempa
On Thu, Mar 21, 2019 at 18:28:54 -0400, Laine Stump wrote: > qemuDomainDetachDeviceControllerLive() just checks if the controller > type is SCSI, and then either returns failure, or calls > qemuDomainDetachControllerDevice(). > > Instead, lets just check for type != SCSI at the top of the latter

[libvirt] [PATCH 14/21] qemu_hotplug: remove extra function in middle of DetachController call chain

2019-03-21 Thread Laine Stump
qemuDomainDetachDeviceControllerLive() just checks if the controller type is SCSI, and then either returns failure, or calls qemuDomainDetachControllerDevice(). Instead, lets just check for type != SCSI at the top of the latter function, and call it directly. Signed-off-by: Laine Stump ---