Re: [libvirt] [PATCH 14.5/16] snapshot: Make virDomainMomentObjListGetNames more generic

2019-03-22 Thread Eric Blake
On 3/22/19 9:00 AM, John Ferlan wrote: > > > On 3/22/19 12:25 AM, Eric Blake wrote: >> Rather than hard-coding the snapshot filter bit values into the >> generic code, add another layer of indirection: callers must map which >> of their public filter bits correspond to supported moment bits, then

Re: [libvirt] [PATCH 14.5/16] snapshot: Make virDomainMomentObjListGetNames more generic

2019-03-22 Thread John Ferlan
On 3/22/19 12:25 AM, Eric Blake wrote: > Rather than hard-coding the snapshot filter bit values into the > generic code, add another layer of indirection: callers must map which > of their public filter bits correspond to supported moment bits, then > pass two separate flags (the ones translated

[libvirt] [PATCH 14.5/16] snapshot: Make virDomainMomentObjListGetNames more generic

2019-03-21 Thread Eric Blake
Rather than hard-coding the snapshot filter bit values into the generic code, add another layer of indirection: callers must map which of their public filter bits correspond to supported moment bits, then pass two separate flags (the ones translated for moment code to operate on, and the remaining