Re: [libvirt] [PATCH 15/19] util: buffer: Reimplement virBuffer internals using glib's GString

2019-10-24 Thread Ján Tomko
On Thu, Oct 24, 2019 at 03:56:33PM +0200, Peter Krempa wrote: GString is surprisingly similar to what libvirt was doing painstaikingly painstakingly Imagine a pancake, but much more convoluted. manually. Yet it doesn't support the automatic indentation features we use for XML so we rather ke

[libvirt] [PATCH 15/19] util: buffer: Reimplement virBuffer internals using glib's GString

2019-10-24 Thread Peter Krempa
GString is surprisingly similar to what libvirt was doing painstaikingly manually. Yet it doesn't support the automatic indentation features we use for XML so we rather keep those in form of virBuffer using GString internally. Signed-off-by: Peter Krempa --- src/util/virbuffer.c | 205 ++