Re: [libvirt] [PATCH 18/16] snapshot: Consolidate writing snapshot state to disk

2019-03-25 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 10:49:04AM -0400, John Ferlan wrote: > > > On 3/20/19 5:32 PM, Eric Blake wrote: > > Remove a now-unused parameter from qemuDomainSnapshotWriteMetadata(). > > Then, instead of calling it after every individual change to a given > > snapshot, call it only once at the end

Re: [libvirt] [PATCH 18/16] snapshot: Consolidate writing snapshot state to disk

2019-03-22 Thread John Ferlan
On 3/20/19 5:32 PM, Eric Blake wrote: > Remove a now-unused parameter from qemuDomainSnapshotWriteMetadata(). > Then, instead of calling it after every individual change to a given > snapshot, call it only once at the end of the API function that > resulted in any overall changes. > >

[libvirt] [PATCH 18/16] snapshot: Consolidate writing snapshot state to disk

2019-03-20 Thread Eric Blake
Remove a now-unused parameter from qemuDomainSnapshotWriteMetadata(). Then, instead of calling it after every individual change to a given snapshot, call it only once at the end of the API function that resulted in any overall changes. Signed-off-by: Eric Blake --- src/qemu/qemu_domain.h | 1 -