Re: [libvirt] [PATCH 18/41] remote: in per-driver daemons ensure that state initialize succeeds

2019-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2019 at 08:25:05PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > [...] > > @@ -648,15 +650,23 @@ virStateInitialize(bool privileged, > [...] > > +if (ret == VIR_DRV_STATE_INIT_ERROR) { > >

Re: [libvirt] [PATCH 18/41] remote: in per-driver daemons ensure that state initialize succeeds

2019-07-26 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: [...] > @@ -648,15 +650,23 @@ virStateInitialize(bool privileged, [...] > +if (ret == VIR_DRV_STATE_INIT_ERROR) { > VIR_ERROR(_("Initialization of %s state driver failed: %s"), >

[libvirt] [PATCH 18/41] remote: in per-driver daemons ensure that state initialize succeeds

2019-07-23 Thread Daniel P . Berrangé
When running in libvirtd, we are happy for any of the drivers to simply skip their initialization in virStateInitialize, as other drivers are still potentially useful. When running in per-driver daemons though, we want the daemon to abort startup if the driver cannot initialize itself, as the