Re: [libvirt] [PATCH 2/2] [TCK] nwfilter: Add test cases for ipset

2012-04-27 Thread Stefan Berger
On 04/26/2012 05:13 PM, Eric Blake wrote: On 04/23/2012 06:20 AM, Stefan Berger wrote: + if [ -n ${cmd} ]; then +eval ${cmd} 21 1/dev/null This says output any errors from command to our stdout, and to ignore normal output of $cmd. Is that what you meant, or did you want to ignore both

Re: [libvirt] [PATCH 2/2] [TCK] nwfilter: Add test cases for ipset

2012-04-27 Thread Eric Blake
On 04/27/2012 05:12 AM, Stefan Berger wrote: On 04/26/2012 05:13 PM, Eric Blake wrote: On 04/23/2012 06:20 AM, Stefan Berger wrote: + if [ -n ${cmd} ]; then +eval ${cmd} 21 1/dev/null This says output any errors from command to our stdout, and to ignore normal output of $cmd. Is that

Re: [libvirt] [PATCH 2/2] [TCK] nwfilter: Add test cases for ipset

2012-04-26 Thread Eric Blake
On 04/23/2012 06:20 AM, Stefan Berger wrote: Add test cases for the ipset extension. Since ipset may not be available on all system, the first line of the XML file containing the test filter has been extended with a specially formatted XML comment containing a command line test for whether

[libvirt] [PATCH 2/2] [TCK] nwfilter: Add test cases for ipset

2012-04-23 Thread Stefan Berger
Add test cases for the ipset extension. Since ipset may not be available on all system, the first line of the XML file containing the test filter has been extended with a specially formatted XML comment containing a command line test for whether the test case can be run at all. The format of that