Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-03-09 Thread Sharadha Prabhakar (3P)
Resending patch 2 as attachment. Sharadha -Original Message- From: Matthias Bolte [mailto:matthias.bo...@googlemail.com] Sent: 05 March 2010 21:42 To: Sharadha Prabhakar (3P) Cc: libvir-list@redhat.com; Ewan Mellor Subject: Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-03-05 Thread Sharadha Prabhakar (3P)
Please see my comments inline. The diff content of PATCH 2/2 with the changes is submitted at the end of this mail. @:@default=/usr/local/lib@:@]),[],[with_libssh2=yes]) AC_ARG_WITH([phyp], AC_HELP_STRING([--with-phyp], [add PHYP support @:@default=check@:@]),[],[with_phyp=check])

Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-03-05 Thread Matthias Bolte
2010/3/5 Sharadha Prabhakar (3P) sharadha.prabha...@citrix.com: Please see my comments inline. The diff content of PATCH 2/2 with the changes is submitted at the end of this mail. Okay, this patch looks good now. I tried to apply it but the patch seems mangled. It seems that you copy and

Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-03-05 Thread Eric Blake
On 03/05/2010 02:42 PM, Matthias Bolte wrote: 2010/3/5 Sharadha Prabhakar (3P) sharadha.prabha...@citrix.com: Please see my comments inline. The diff content of PATCH 2/2 with the changes is submitted at the end of this mail. Okay, this patch looks good now. I tried to apply it but the

Re: [libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-03-04 Thread Matthias Bolte
2010/2/26 Sharadha Prabhakar (3P) sharadha.prabha...@citrix.com: This is the last patch in this series. It contains changes made to the following files. ~/libvirt/configure.ac ~/libvirt/src/Makefile.am ~/libvirt/src/util/virterror.c ~/libvirt/src/driver.h

[libvirt] [PATCH 2/2] Addition of XenAPI support to libvirt

2010-02-26 Thread Sharadha Prabhakar (3P)
This is the last patch in this series. It contains changes made to the following files. ~/libvirt/configure.ac ~/libvirt/src/Makefile.am ~/libvirt/src/util/virterror.c ~/libvirt/src/driver.h ~/libvirt/include/libvirt/virterror.h ~/libvirt/virterror.c --- ./libvirt_org/configure.ac 2010-02-17