[libvirt] [PATCH 2/2] Implementation deficiency in virInitctlSetRunLevel v4

2013-12-20 Thread Reco
Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and lxcDomainReboot. --- src/lxc/lxc_driver.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index e5298d1..2385f5b

Re: [libvirt] [PATCH 2/2] Implementation deficiency in virInitctlSetRunLevel v4

2013-12-20 Thread Daniel P. Berrange
On Fri, Dec 20, 2013 at 08:24:52PM +0400, Reco wrote: Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and lxcDomainReboot. --- src/lxc/lxc_driver.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] Implementation deficiency in virInitctlSetRunLevel v4

2013-12-20 Thread Eric Blake
On 12/20/2013 09:24 AM, Reco wrote: Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and lxcDomainReboot. This fails to compile, due to [1] below: CCLD libvirt_lxc lxc/lxc_driver.c:2783:1: error: return type defaults to 'int' [-Werror] virDomainRebootCallback(pid_t

Re: [libvirt] [PATCH 2/2] Implementation deficiency in virInitctlSetRunLevel v4

2013-12-20 Thread Eric Blake
On 12/20/2013 01:41 PM, Eric Blake wrote: On 12/20/2013 09:24 AM, Reco wrote: Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and lxcDomainReboot. static int +virDomainShutdownCallback(pid_t pid ATTRIBUTE_UNUSED, + void *opaque ATTRIBUTE_UNUSED)