Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-31 Thread Paolo Bonzini
On 03/31/2011 01:18 PM, Michal Novotny wrote: You mean to compare command-line from the XML, i.e. to generate the command-line from XML and put the tests whether the generated command-line is the same as mentioned in the *.argv file containing whole command-line? Like for QEMU? Yes. Paolo --

Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-31 Thread Michal Novotny
On 03/31/2011 01:14 PM, Paolo Bonzini wrote: > On 03/31/2011 01:06 PM, Michal Novotny wrote: - this would be the third patch in the series, and it would add dnsmasqAddHost calls in networkSaveDnsmasqHostsfile >> So this patch will be just adding the networkSaveDnsmasqHostsfile() call >>

Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-31 Thread Paolo Bonzini
On 03/31/2011 01:06 PM, Michal Novotny wrote: > - this would be the third patch in the series, and it would add > dnsmasqAddHost calls in networkSaveDnsmasqHostsfile So this patch will be just adding the networkSaveDnsmasqHostsfile() call to the dnsmasqAddHost() and nothing else ? And all th

Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-31 Thread Michal Novotny
On 03/31/2011 10:16 AM, Paolo Bonzini wrote: >> + >> + >> + >> + >> + >> + > oneOrMore hostname elements seems preferrable. Well, this could be better. That's right. >> +if ((fd = open(hostsFile, > You can use fopen and fprintf. Well, I don't know since it's rarely used in to fopen and f

Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-31 Thread Paolo Bonzini
+ + + + + + oneOrMore hostname elements seems preferrable. +if ((fd = open(hostsFile, You can use fopen and fprintf. This function also should be in src/util/dnsmasq.c (e.g. with addnhost* APIs in that file and dnsmasqAddHost as a public API). See the hostsfile* APIs there. Then yo

[libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

2011-03-30 Thread Michal Novotny
Hi, this is the patch to add support for defining the hosts into the DNS service on the virtual network. You can define the host IP address and the aliases for the IP address. The DNS hosts record can be defined in the XML file as the host element in this form: example1 example2