Re: [libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-30 Thread Wen Congyang
At 03/29/2011 09:58 PM, Jiri Denemark Write: > On Tue, Mar 29, 2011 at 17:48:48 +0800, Wen Congyang wrote: >> diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c >> index eed83f4..647e2bb 100644 >> --- a/src/qemu/qemu_monitor.c >> +++ b/src/qemu/qemu_monitor.c >> @@ -906,7 +906,14 @@ int

Re: [libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Jiri Denemark
On Tue, Mar 29, 2011 at 17:48:48 +0800, Wen Congyang wrote: > diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c > index eed83f4..647e2bb 100644 > --- a/src/qemu/qemu_monitor.c > +++ b/src/qemu/qemu_monitor.c > @@ -906,7 +906,14 @@ int qemuMonitorSetCapabilities(qemuMonitorPtr mon) >

Re: [libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Daniel P. Berrange
On Tue, Mar 29, 2011 at 05:48:48PM +0800, Wen Congyang wrote: > If qemu quited unexpectedly when we call qemuMonitorJSONHMP(), > libvirt will crash. > Steps to reproduce this bug: > 1. use gdb to attach libvirtd, and set a breakpoint in the function >qemuMonitorSetCapabilities() > 2. start a vm

[libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Wen Congyang
If qemu quited unexpectedly when we call qemuMonitorJSONHMP(), libvirt will crash. Steps to reproduce this bug: 1. use gdb to attach libvirtd, and set a breakpoint in the function qemuMonitorSetCapabilities() 2. start a vm 3. let the libvirtd to run until qemuMonitorJSONSetCapabilities() returns