Re: [libvirt] [PATCH 2/2] domain_conf: allow CDROM/Floppy media change with attach-device

2019-04-11 Thread Michal Privoznik
On 4/10/19 11:49 PM, Daniel Henrique Barboza wrote: Commit f1d6585300 ("domain_conf: check device address before attach") added an address verification for all devices, avoiding calling the driver attach() for a case in which we know that the device would have duplicated address. That commit fai

[libvirt] [PATCH 2/2] domain_conf: allow CDROM/Floppy media change with attach-device

2019-04-10 Thread Daniel Henrique Barboza
Commit f1d6585300 ("domain_conf: check device address before attach") added an address verification for all devices, avoiding calling the driver attach() for a case in which we know that the device would have duplicated address. That commit failed to contemplate the case of CDROM/Floppy devices th