[libvirt] [PATCH 2/2] hostdev: Remove temporary variable when checking for VF

2016-02-25 Thread Andrea Bolognani
The virHostdevIsVirtualFunction() was called exactly twice, and in both cases the return value was saved to a temporary variable before being checked. This would be okay if it improved readability, but in this case is pretty pointless. Get rid of the temporary variable and check the return value d

Re: [libvirt] [PATCH 2/2] hostdev: Remove temporary variable when checking for VF

2016-02-25 Thread Michal Privoznik
On 25.02.2016 14:02, Andrea Bolognani wrote: > The virHostdevIsVirtualFunction() was called exactly twice, and in > both cases the return value was saved to a temporary variable before > being checked. This would be okay if it improved readability, but in > this case is pretty pointless. > > Get r

Re: [libvirt] [PATCH 2/2] hostdev: Remove temporary variable when checking for VF

2016-02-25 Thread Andrea Bolognani
On Thu, 2016-02-25 at 15:51 +0100, Michal Privoznik wrote: > On 25.02.2016 14:02, Andrea Bolognani wrote: > > > > The virHostdevIsVirtualFunction() was called exactly twice, and in > > both cases the return value was saved to a temporary variable before > > being checked. This would be okay if it