Re: [libvirt] [PATCH 2/2] libvirt-rust Fix Stream::send

2019-10-18 Thread Martin Kletzander
On Wed, Oct 16, 2019 at 01:49:51PM +0200, Sahid Orentino Ferdjaoui wrote: On Fri, Sep 20, 2019 at 10:02:47AM +0200, Martin Kletzander wrote: On Thu, Sep 19, 2019 at 05:48:49AM +, Linus Färnstrand wrote: > * Handle the -2 error case > * Allow sending arbitrary byte array, not just UTF-8

Re: [libvirt] [PATCH 2/2] libvirt-rust Fix Stream::send

2019-10-16 Thread Sahid Orentino Ferdjaoui
On Fri, Sep 20, 2019 at 10:02:47AM +0200, Martin Kletzander wrote: > On Thu, Sep 19, 2019 at 05:48:49AM +, Linus Färnstrand wrote: > > * Handle the -2 error case > > * Allow sending arbitrary byte array, not just UTF-8 strings > > * Fix FFI declaration, takes size_t, not c_uint > > * Return

Re: [libvirt] [PATCH 2/2] libvirt-rust Fix Stream::send

2019-09-20 Thread Martin Kletzander
On Thu, Sep 19, 2019 at 05:48:49AM +, Linus Färnstrand wrote: * Handle the -2 error case * Allow sending arbitrary byte array, not just UTF-8 strings * Fix FFI declaration, takes size_t, not c_uint * Return usize to be more idiomatic (type used for slice indexing) Signed-off-by: Linus

[libvirt] [PATCH 2/2] libvirt-rust Fix Stream::send

2019-09-19 Thread Linus Färnstrand
* Handle the -2 error case * Allow sending arbitrary byte array, not just UTF-8 strings * Fix FFI declaration, takes size_t, not c_uint * Return usize to be more idiomatic (type used for slice indexing) Signed-off-by: Linus Färnstrand --- src/stream.rs | 21 ++--- 1 file