Re: [libvirt] [PATCH 2/2] lxc: check actual type of interface not config type

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 09:35:13PM -0500, Laine Stump wrote: > virLXCControllerGetNICIndexes() was deciding whether or not to add the > ifindex for an interface's ifname to the list of ifindexes sent to > CreateMachineWithNetwork based on the interface type stored in the > config. This would be

[libvirt] [PATCH 2/2] lxc: check actual type of interface not config type

2018-12-05 Thread Laine Stump
virLXCControllerGetNICIndexes() was deciding whether or not to add the ifindex for an interface's ifname to the list of ifindexes sent to CreateMachineWithNetwork based on the interface type stored in the config. This would be incorrect in the case of where the network was giving out macvlan