On 12/19/2013 08:17 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
+++ b/src/libvirt_internal.h
@@ -27,6 +27,113 @@
# include
On Thu, Dec 19, 2013 at 09:35:23AM -0700, Eric Blake wrote:
On 12/19/2013 08:17 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
On 12/19/2013 09:37 AM, Daniel P. Berrange wrote:
+#define virLibDomainSnapshotError(code, ...) \
+virReportErrorHelper(VIR_FROM_DOMAIN_SNAPSHOT, code, __FILE__, \
+ __FUNCTION__, __LINE__, __VA_ARGS__)
I'd venture to sugggest that these
I noticed that the virDomainQemuMonitorCommand debug output wasn't
telling me the name of the domain it was working on. While it was
easy enough to determine which pointer matches the domain based on
other log messages, it is nicer to be consistent. Along the same
lines, having
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
+++ b/src/libvirt_internal.h
@@ -27,6 +27,113 @@
# include internal.h
+/* Helper macros to implement
