Re: [libvirt] [PATCH 2/2] maint: reject raw close, popen in 'make syntax-check'

2011-01-28 Thread Eric Blake
On 01/28/2011 04:04 PM, Matthias Bolte wrote: >> +++ b/.x-sc_prohibit_close >> @@ -1,3 +1,9 @@ >> +# Non-C files: >> ^docs/.* >> +^ChangeLog* >> ^HACKING$ >> +*.py$ > > Shouldn't the dot be escaped here like in the other lines you added? > >> +# Wrapper implementation: >> ^src/util/files.c$ >

Re: [libvirt] [PATCH 2/2] maint: reject raw close, popen in 'make syntax-check'

2011-01-28 Thread Matthias Bolte
2011/1/28 Eric Blake : > commit f1fe9671e was supposed to make sure we use files.h > macros to avoid double close, but it didn't work. > > Meanwhile, virCommand is vastly superior to system(), fork(), > and popen() (also to virExec, but we haven't completed that > conversion), so enforce that, too.

[libvirt] [PATCH 2/2] maint: reject raw close, popen in 'make syntax-check'

2011-01-28 Thread Eric Blake
commit f1fe9671e was supposed to make sure we use files.h macros to avoid double close, but it didn't work. Meanwhile, virCommand is vastly superior to system(), fork(), and popen() (also to virExec, but we haven't completed that conversion), so enforce that, too. * cfg.mk (sc_prohibit_close): Fi