Re: [libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator

2010-03-26 Thread Jim Meyering
Eric Blake wrote: On 03/25/2010 02:22 AM, Jim Meyering wrote: -# Using test's -a operator is not portable. -sc_prohibit_test_minus_a: +# Using test's -a and -o operators is not portable. +sc_prohibit_test_minus_ao: @re='\test .+ -[a] ' \

Re: [libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator

2010-03-25 Thread Jim Meyering
Eric Blake wrote: * cfg.mk (sc_prohibit_test_minus_a): Rename... (sc_prohibit_test_minus_ao): ...and flag '-o', too. --- cfg.mk |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4302338..27cfca4 100644 --- a/cfg.mk +++ b/cfg.mk @@

Re: [libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator

2010-03-25 Thread Eric Blake
On 03/25/2010 02:22 AM, Jim Meyering wrote: -# Using test's -a operator is not portable. -sc_prohibit_test_minus_a: +# Using test's -a and -o operators is not portable. +sc_prohibit_test_minus_ao: @re='\test .+ -[a] ' \ msg='use test C1

[libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator

2010-03-24 Thread Eric Blake
* cfg.mk (sc_prohibit_test_minus_a): Rename... (sc_prohibit_test_minus_ao): ...and flag '-o', too. --- cfg.mk |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4302338..27cfca4 100644 --- a/cfg.mk +++ b/cfg.mk @@ -269,11 +269,14 @@