Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-20 Thread Osier Yang
On 17/01/14 21:44, John Ferlan wrote: On 01/17/2014 02:06 AM, Osier Yang wrote: ...snip... As a conclusion, I think the only concern from you is about the problem on the running domain of an old libvirt (without these 2 patches). Right? If so, my thought is to add document somewhere, though I

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-17 Thread John Ferlan
On 01/17/2014 02:06 AM, Osier Yang wrote: ...snip... As a conclusion, I think the only concern from you is about the problem on the running domain of an old libvirt (without these 2 patches). Right? If so, my thought is to add document somewhere, though I have not much idea about where to

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-16 Thread Osier Yang
On 16/01/14 08:51, John Ferlan wrote: On 01/08/2014 09:51 AM, Osier Yang wrote: It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails).

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-16 Thread Osier Yang
[ shrinked ] --- src/libvirt_private.syms | 2 +- src/qemu/qemu_hostdev.c | 75 ++-- src/util/virscsi.c | 48 +-- src/util/virscsi.h | 7 +++-- 4 files changed, 84 insertions(+), 48 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-16 Thread John Ferlan
On 01/16/2014 08:53 AM, Osier Yang wrote: ...snip... It took some thinking, but I convinced myself that this path doesn't need the shared check since it's only called from qemuProcessReconnect; however, if something else did call it some day then that check may be necessary. It may be

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-16 Thread Osier Yang
On 16/01/14 23:39, John Ferlan wrote: On 01/16/2014 08:53 AM, Osier Yang wrote: ...snip... It took some thinking, but I convinced myself that this path doesn't need the shared check since it's only called from qemuProcessReconnect; however, if something else did call it some day then that

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-15 Thread John Ferlan
On 01/08/2014 09:51 AM, Osier Yang wrote: It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails). To fix the problem, this patch

[libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-08 Thread Osier Yang
It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails). To fix the problem, this patch introduces an array for virSCSIDevice struct, which

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-07 Thread Osier Yang
On 06/01/14 23:54, John Ferlan wrote: On 01/02/2014 09:45 AM, Osier Yang wrote: It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails).

Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-06 Thread John Ferlan
On 01/02/2014 09:45 AM, Osier Yang wrote: It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails). Also don't try to add the device

[libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains

2014-01-02 Thread Osier Yang
It doesn't make sense to fail if the SCSI host device is specified as shareable explicitly between domains (NB, it works if and only if the device is specified as shareable for *all* domains, otherwise it fails). Also don't try to add the device to the activeScsiHostdevs list if it's already