Re: [libvirt] [PATCH 2/2] qemu: Enforce vCPU hotplug granularity constraints

2017-12-15 Thread Andrea Bolognani
On Fri, 2017-12-15 at 13:22 +0100, Peter Krempa wrote: > > + > > +if (!def->cpu || def->cpu->sockets == 0) > > +return 1; > > I think we assume '1' as threads here if it's not specified. Okay. > > + > > +if (qemuDomainIsPSeries(def)) > > +*granularity = def->cpu->threads;

Re: [libvirt] [PATCH 2/2] qemu: Enforce vCPU hotplug granularity constraints

2017-12-15 Thread Peter Krempa
On Thu, Dec 14, 2017 at 17:29:51 +0100, Andrea Bolognani wrote: > QEMU 2.7 and newer don't allow guests to start unless the initial > vCPUs count is a multiple of the vCPU hotplug granularity, so > validate it and report an error if needed. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id

[libvirt] [PATCH 2/2] qemu: Enforce vCPU hotplug granularity constraints

2017-12-14 Thread Andrea Bolognani
QEMU 2.7 and newer don't allow guests to start unless the initial vCPUs count is a multiple of the vCPU hotplug granularity, so validate it and report an error if needed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283700 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c