Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 03:52:09PM +0200, Paolo Bonzini wrote: > > > On 05/07/2016 14:59, Daniel P. Berrange wrote: > > > if (!def->ngraphics) { > > > -virCommandAddArg(cmd, "-nographic"); > > > +if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) { > > > +virCommand

Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Paolo Bonzini
On 05/07/2016 14:59, Daniel P. Berrange wrote: > > if (!def->ngraphics) { > > -virCommandAddArg(cmd, "-nographic"); > > +if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) { > > +virCommandAddArg(cmd, "-display"); > > +virCommandAddArg(cmd, "none"); > >

Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 02:35:28PM +0200, Paolo Bonzini wrote: > This is preferrable to -nographic which (in addition to disabling > graphics output) redirects the serial port to stdio and on OpenBIOS > enables the firmware's serial console. > > Signed-off-by: Paolo Bonzini > --- > src/qemu/qemu

[libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Paolo Bonzini
This is preferrable to -nographic which (in addition to disabling graphics output) redirects the serial port to stdio and on OpenBIOS enables the firmware's serial console. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_command.c| 7 - src/qemu/qemu_parse_command