Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-11-03 Thread Ján Tomko
On 11/03/2014 05:22 AM, weiwei li wrote: mig-nbd is initialized by qemuMigrationCookieXMLParse(called by qemuMigrationEatCookie),with a condition that the nbd infomation contained in Cookie string. I found in debug info that qemuMigrationStartNBDServer had been called in

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-11-03 Thread weiwei li
agree,I have tested the flag and it works well, i will post another patch later. Thanks very much! 2014-11-03 20:03 GMT+08:00 Ján Tomko jto...@redhat.com: On 11/03/2014 05:22 AM, weiwei li wrote: mig-nbd is initialized by qemuMigrationCookieXMLParse(called by qemuMigrationEatCookie),with a

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-11-02 Thread weiwei li
mig-nbd is initialized by qemuMigrationCookieXMLParse(called by qemuMigrationEatCookie),with a condition that the nbd infomation contained in Cookie string. I found in debug info that qemuMigrationStartNBDServer had been called in qemuMigrationPrepareAny(mig-nbd not null), but at in

[libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-10-31 Thread weiwei li
qemuMigrationCookiePtr mig-nbd may be null when MigrationCookie do not have nbd information ,but nbd port did allocated before and must be released here, so ignore mig-nbd null ptr and just warn. Signed-off-by: Weiwei Li nuonu...@tencent.com --- src/qemu/qemu_migration.c |2 +- 1 files

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-10-31 Thread Ján Tomko
On 10/31/2014 09:17 AM, weiwei li wrote: qemuMigrationCookiePtr mig-nbd may be null when MigrationCookie do not have nbd information ,but nbd port did allocated before and must be released here, so ignore mig-nbd null ptr and just warn. StartNBDServer is only run when mig-nbd is present, so if