Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-12-14 Thread Cole Robinson
On 11/10/2016 05:59 AM, Daniel P. Berrange wrote: > On Thu, Nov 10, 2016 at 10:35:46AM +, Marc-André Lureau wrote: >> Hi >> >> What's the status with this patch? If I understand the discussion, it is >> needed, but not enough. Now that SELinux has been fixed (both in f24/f25 >> now), I can see

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2016 at 10:35:46AM +, Marc-André Lureau wrote: > Hi > > What's the status with this patch? If I understand the discussion, it is > needed, but not enough. Now that SELinux has been fixed (both in f24/f25 > now), I can see only the ACL left: setfacl -m u:qemu:rw

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-11-10 Thread Marc-André Lureau
Hi What's the status with this patch? If I understand the discussion, it is needed, but not enough. Now that SELinux has been fixed (both in f24/f25 now), I can see only the ACL left: setfacl -m u:qemu:rw /dev/dri/renderD128 + this patch allows me to setup a system VM with virgl. (though tbh, I

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-20 Thread Cole Robinson
On 05/20/2016 03:54 AM, Ján Tomko wrote: > On Thu, May 19, 2016 at 01:52:00PM +0100, Daniel P. Berrange wrote: >> On Thu, May 19, 2016 at 08:36:35AM -0400, Cole Robinson wrote: >>> On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote:

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-20 Thread Daniel P. Berrange
On Fri, May 20, 2016 at 09:54:29AM +0200, Ján Tomko wrote: > On Thu, May 19, 2016 at 01:52:00PM +0100, Daniel P. Berrange wrote: > > On Thu, May 19, 2016 at 08:36:35AM -0400, Cole Robinson wrote: > > > On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: > > > > On Thu, May 19, 2016 at 01:29:07PM

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-20 Thread Ján Tomko
On Thu, May 19, 2016 at 01:52:00PM +0100, Daniel P. Berrange wrote: > On Thu, May 19, 2016 at 08:36:35AM -0400, Cole Robinson wrote: > > On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: > > > On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote: > > >> Allow access to /dev/dri/render*

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Dave Airlie
On 20 May 2016 at 00:23, Daniel P. Berrange wrote: > On Thu, May 19, 2016 at 04:12:52PM +0200, Gerd Hoffmann wrote: >> Hi, >> >> > $ ls -lZ /dev/dri/ >> > total 0 >> > crw-rw+ 1 root video system_u:object_r:dri_device_t:s0 226, 0 May 18 >> > 19:17 card0 >> >

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Daniel P. Berrange
On Thu, May 19, 2016 at 04:12:52PM +0200, Gerd Hoffmann wrote: > Hi, > > > $ ls -lZ /dev/dri/ > > total 0 > > crw-rw+ 1 root video system_u:object_r:dri_device_t:s0 226, 0 May 18 > > 19:17 card0 > > crw---. 1 root video system_u:object_r:dri_device_t:s0 226, 64 May 18 > > 19:17

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Gerd Hoffmann
Hi, > $ ls -lZ /dev/dri/ > total 0 > crw-rw+ 1 root video system_u:object_r:dri_device_t:s0 226, 0 May 18 > 19:17 card0 > crw---. 1 root video system_u:object_r:dri_device_t:s0 226, 64 May 18 > 19:17 controlD64 > crw-rw+ 1 root video system_u:object_r:dri_device_t:s0 226, 128 May

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Cole Robinson
On 05/19/2016 08:52 AM, Daniel P. Berrange wrote: > On Thu, May 19, 2016 at 08:36:35AM -0400, Cole Robinson wrote: >> On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: >>> On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote: Allow access to /dev/dri/render* devices for domains

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Daniel P. Berrange
On Thu, May 19, 2016 at 08:36:35AM -0400, Cole Robinson wrote: > On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: > > On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote: > >> Allow access to /dev/dri/render* devices for domains > >> using with > >> > >>

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Cole Robinson
On 05/19/2016 08:21 AM, Daniel P. Berrange wrote: > On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote: >> Allow access to /dev/dri/render* devices for domains >> using with >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1337290 > > Ignoring cgroups for a minute, how exactly does QEMU

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Daniel P. Berrange
On Thu, May 19, 2016 at 01:29:07PM +0200, Ján Tomko wrote: > Allow access to /dev/dri/render* devices for domains > using with > > https://bugzilla.redhat.com/show_bug.cgi?id=1337290 Ignoring cgroups for a minute, how exactly does QEMU get access to the /dev/dri/render* devices in general ?

[libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-05-19 Thread Ján Tomko
Allow access to /dev/dri/render* devices for domains using with https://bugzilla.redhat.com/show_bug.cgi?id=1337290 --- src/qemu/qemu_cgroup.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c