Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-20 Thread Daniel P . Berrangé
On Wed, Jun 20, 2018 at 11:14:41AM +0200, Marc Hartmayer wrote: > On Tue, Jun 19, 2018 at 05:03 PM +0200, "Daniel P. Berrangé" > wrote: > > On Tue, Jun 19, 2018 at 03:55:09PM +0100, Daniel P. Berrangé wrote: > >> On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: > >> > On Mon, Jun

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Marc Hartmayer
On Tue, Jun 19, 2018 at 05:30 PM +0200, "Daniel P. Berrangé" wrote: > On Tue, Jun 19, 2018 at 05:18:17PM +0200, Marc Hartmayer wrote: >> On Tue, Jun 19, 2018 at 04:55 PM +0200, "Daniel P. Berrangé" >> wrote: >> > On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: >> >> On Mon, Jun

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 05:18:17PM +0200, Marc Hartmayer wrote: > On Tue, Jun 19, 2018 at 04:55 PM +0200, "Daniel P. Berrangé" > wrote: > > On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: > >> On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: > >> > On Mon, Jun 18,

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Marc Hartmayer
On Tue, Jun 19, 2018 at 05:03 PM +0200, "Daniel P. Berrangé" wrote: > On Tue, Jun 19, 2018 at 03:55:09PM +0100, Daniel P. Berrangé wrote: >> On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: >> > On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: >> > > On Mon, Jun 18,

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Marc Hartmayer
On Tue, Jun 19, 2018 at 04:55 PM +0200, "Daniel P. Berrangé" wrote: > On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: >> On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: >> > On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety >> > wrote: >> > > On Fri, Jun 15,

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 03:55:09PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: > > On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: > > > On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety > > > wrote: > > > > On Fri, Jun

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 04:51:13PM +0200, Erik Skultety wrote: > On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: > > On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety > > wrote: > > > On Fri, Jun 15, 2018 at 03:31:34PM +0200, Marc Hartmayer wrote: > > >> On Fri, Jun 15, 2018

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-19 Thread Erik Skultety
On Mon, Jun 18, 2018 at 12:38:06PM +0200, Marc Hartmayer wrote: > On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety > wrote: > > On Fri, Jun 15, 2018 at 03:31:34PM +0200, Marc Hartmayer wrote: > >> On Fri, Jun 15, 2018 at 01:39 PM +0200, Marc Hartmayer > >> wrote: > >> > If srv->workers is

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-18 Thread Marc Hartmayer
On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety wrote: > On Fri, Jun 15, 2018 at 03:31:34PM +0200, Marc Hartmayer wrote: >> On Fri, Jun 15, 2018 at 01:39 PM +0200, Marc Hartmayer >> wrote: >> > If srv->workers is a NULL pointer, as it is the case if there are no >> > workers, then don't

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-18 Thread Marc Hartmayer
On Mon, Jun 18, 2018 at 09:47 AM +0200, Erik Skultety wrote: > On Fri, Jun 15, 2018 at 03:31:34PM +0200, Marc Hartmayer wrote: >> On Fri, Jun 15, 2018 at 01:39 PM +0200, Marc Hartmayer >> wrote: >> > If srv->workers is a NULL pointer, as it is the case if there are no >> > workers, then don't

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-18 Thread Erik Skultety
On Fri, Jun 15, 2018 at 03:31:34PM +0200, Marc Hartmayer wrote: > On Fri, Jun 15, 2018 at 01:39 PM +0200, Marc Hartmayer > wrote: > > If srv->workers is a NULL pointer, as it is the case if there are no > > workers, then don't try to dereference it. > > > > Signed-off-by: Marc Hartmayer > >

Re: [libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-15 Thread Marc Hartmayer
On Fri, Jun 15, 2018 at 01:39 PM +0200, Marc Hartmayer wrote: > If srv->workers is a NULL pointer, as it is the case if there are no > workers, then don't try to dereference it. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/rpc/virnetserver.c | 22

[libvirt] [PATCH 2/2] rpc: Fix segmentation fault when no worker pool is available

2018-06-15 Thread Marc Hartmayer
If srv->workers is a NULL pointer, as it is the case if there are no workers, then don't try to dereference it. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/rpc/virnetserver.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git