Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > The current LUKS support has a "luks" volume type which has > > a "luks" encryption format. > > > > This partially makes sense if you consider the QEMU

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Martin Kletzander
On Wed, Jul 27, 2016 at 10:23:18AM +0100, Daniel P. Berrange wrote: On Wed, Jul 27, 2016 at 11:16:57AM +0200, Martin Kletzander wrote: On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: > On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > > On Tue, Jul 26,

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2016 at 11:16:57AM +0200, Martin Kletzander wrote: > On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: > > On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > > > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > > > The

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Martin Kletzander
On Wed, Jul 27, 2016 at 09:29:29AM +0100, Daniel P. Berrange wrote: On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > The current LUKS support has a "luks" volume type which has > a "luks" encryption format.

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2016 at 08:44:53AM +0200, Martin Kletzander wrote: > On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: > > The current LUKS support has a "luks" volume type which has > > a "luks" encryption format. > > > > This partially makes sense if you consider the QEMU

Re: [libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-27 Thread Martin Kletzander
On Tue, Jul 26, 2016 at 07:12:30PM +0100, Daniel P. Berrange wrote: The current LUKS support has a "luks" volume type which has a "luks" encryption format. This partially makes sense if you consider the QEMU shorthand syntax only requires you to specify a format=luks, and it'll automagically

[libvirt] [PATCH 2/2] storage: remove "luks" storage volume type

2016-07-26 Thread Daniel P. Berrange
The current LUKS support has a "luks" volume type which has a "luks" encryption format. This partially makes sense if you consider the QEMU shorthand syntax only requires you to specify a format=luks, and it'll automagically uses "raw" as the next level driver. QEMU will however let you override