Re: [libvirt] [PATCH 2/2] virnetsockettest: Use a temporary directory in /tmp

2011-11-03 Thread Guido Günther
On Wed, Nov 02, 2011 at 04:28:54PM -0600, Eric Blake wrote: On 11/02/2011 04:00 PM, Guido Günther wrote: +template = strdup(/tmp/libvirt_XX); No need to malloc() the template. Just do: char template[] = /tmp/libvirt_XX; This was actually the first version I had but it

[libvirt] [PATCH 2/2] virnetsockettest: Use a temporary directory in /tmp

2011-11-02 Thread Guido Günther
to avoid exceeding UNIX_PATH_MAX --- tests/virnetsockettest.c | 60 ++--- 1 files changed, 40 insertions(+), 20 deletions(-) diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index 6320ce0..aeb4f3f 100644 --- a/tests/virnetsockettest.c +++

Re: [libvirt] [PATCH 2/2] virnetsockettest: Use a temporary directory in /tmp

2011-11-02 Thread Eric Blake
On 11/02/2011 03:31 PM, Guido Günther wrote: to avoid exceeding UNIX_PATH_MAX --- tests/virnetsockettest.c | 60 ++--- 1 files changed, 40 insertions(+), 20 deletions(-) I like this better than Stefan's proposal (a temporary directory is better

Re: [libvirt] [PATCH 2/2] virnetsockettest: Use a temporary directory in /tmp

2011-11-02 Thread Guido Günther
On Wed, Nov 02, 2011 at 03:39:54PM -0600, Eric Blake wrote: On 11/02/2011 03:31 PM, Guido Günther wrote: to avoid exceeding UNIX_PATH_MAX --- tests/virnetsockettest.c | 60 ++--- 1 files changed, 40 insertions(+), 20 deletions(-) I like this