Re: [libvirt] [PATCH 2/3] Make umlConnectTapDevice ask brAddTap for a persistent tap device.

2010-08-12 Thread Soren Hansen
On 12-08-2010 14:20, Daniel P. Berrange wrote: -brShutdown(brctl); brShutdown doesn't touch the bridge device at all. This simply closes the socket file handle we used for talking to the kernel to create the bridge. Removing this causes an FD leak Hm, so it does. I'll put it back. Regard

Re: [libvirt] [PATCH 2/3] Make umlConnectTapDevice ask brAddTap for a persistent tap device.

2010-08-12 Thread Daniel P. Berrange
On Thu, Aug 12, 2010 at 12:10:25AM +0200, Soren Hansen wrote: > This patch does two things: > > * It makes umlConnectTapDevice ask brAddTap for a persistent tap by >passing it a NULL tapfd argument. > * Stops umlConnectTapDevice from immediately dismantling the bridge >it just set up. >

[libvirt] [PATCH 2/3] Make umlConnectTapDevice ask brAddTap for a persistent tap device.

2010-08-12 Thread Soren Hansen
This patch does two things: * It makes umlConnectTapDevice ask brAddTap for a persistent tap by passing it a NULL tapfd argument. * Stops umlConnectTapDevice from immediately dismantling the bridge it just set up. Signed-off-by: Soren Hansen --- src/uml/uml_conf.c |6 +- 1 files