Re: [libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files

2013-03-28 Thread Peter Krempa
On 03/27/13 22:45, Eric Blake wrote: On 03/26/2013 08:06 AM, Martin Kletzander wrote: On 03/26/2013 12:26 PM, Peter Krempa wrote: Format the address using the helper to avoid code duplication. --- src/conf/domain_conf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) I'd ACK

Re: [libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files

2013-03-27 Thread Eric Blake
On 03/26/2013 08:06 AM, Martin Kletzander wrote: On 03/26/2013 12:26 PM, Peter Krempa wrote: Format the address using the helper to avoid code duplication. --- src/conf/domain_conf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) I'd ACK that, fine use for the cleanup, but

[libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files

2013-03-26 Thread Peter Krempa
Format the address using the helper to avoid code duplication. --- src/conf/domain_conf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4cae0d3..40dfc99 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files

2013-03-26 Thread Martin Kletzander
On 03/26/2013 12:26 PM, Peter Krempa wrote: Format the address using the helper to avoid code duplication. --- src/conf/domain_conf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4cae0d3..40dfc99 100644