Re: [libvirt] [PATCH 2/3] domain: Define explicit flags for saved image xml

2019-02-14 Thread Daniel P . Berrangé
On Wed, Feb 13, 2019 at 05:22:50PM -0600, Eric Blake wrote: > Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0)

[libvirt] [PATCH 2/3] domain: Define explicit flags for saved image xml

2019-02-13 Thread Eric Blake
Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use of @flags as a subset of virDomainXMLFlags, documenting that 2 of the 3 flags defined at the time would never be valid. Later, commit 28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but did not adjust the save