Re: [libvirt] [PATCH 2/3] libxl: fix segfault in libxlReconnectDomain

2016-07-28 Thread Cedric Bosdonnat
On Wed, 2016-07-27 at 17:40 +0100, Joao Martins wrote: > > This commit also factorizes code between the error and normal ends. > Also noticed in the rest of the patches, but I think you forgot to include > the SoB tag (Signed-off-by). I never include it and it's not mandatory here in the libvirt

Re: [libvirt] [PATCH 2/3] libxl: fix segfault in libxlReconnectDomain

2016-07-27 Thread Joao Martins
On 07/27/2016 02:42 PM, Cédric Bosdonnat wrote: > In case of error, libxlReconnectDomain may call > virDomainObjListRemoveLocked. However it has no local reference on > the domain object, leading to segfault. Get a reference to the domain > object at the start of the function and release it at

[libvirt] [PATCH 2/3] libxl: fix segfault in libxlReconnectDomain

2016-07-27 Thread Cédric Bosdonnat
In case of error, libxlReconnectDomain may call virDomainObjListRemoveLocked. However it has no local reference on the domain object, leading to segfault. Get a reference to the domain object at the start of the function and release it at the end to avoid problems. This commit also factorizes