Re: [libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-21 Thread Michal Privoznik
On 19.08.2016 17:26, Laine Stump wrote: >> Moreover, if the value has been modified, we can't be >> entirely sure it was modified to something outside boundaries. It might >> as well be changed from 'no' to 'yes' (or vice versa) which is not any >> worse than the previous case IMO. > > I don't

Re: [libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-19 Thread Laine Stump
On 08/19/2016 02:50 AM, Michal Privoznik wrote: On 18.08.2016 20:42, Laine Stump wrote: On Aug 18, 2016 5:01 AM, "Michal Privoznik" wrote: On 12.08.2016 04:41, Laine Stump wrote: def->nsrvs || def->ntxts)) return 0; virBufferAddLit(buf, "enable) { +const c

Re: [libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-18 Thread Michal Privoznik
On 18.08.2016 20:42, Laine Stump wrote: > On Aug 18, 2016 5:01 AM, "Michal Privoznik" wrote: >> >> On 12.08.2016 04:41, Laine Stump wrote: >>> If you define a libvirt virtual network with one or more IP addresses, >>> it starts up an instance of dnsmasq. It's always been possible to >>> avoid dnsm

Re: [libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-18 Thread Laine Stump
On Aug 18, 2016 5:01 AM, "Michal Privoznik" wrote: > > On 12.08.2016 04:41, Laine Stump wrote: > > If you define a libvirt virtual network with one or more IP addresses, > > it starts up an instance of dnsmasq. It's always been possible to > > avoid dnsmasq's dhcp server (simply don't include a e

Re: [libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-18 Thread Michal Privoznik
On 12.08.2016 04:41, Laine Stump wrote: > If you define a libvirt virtual network with one or more IP addresses, > it starts up an instance of dnsmasq. It's always been possible to > avoid dnsmasq's dhcp server (simply don't include a element), > but until now it wasn't possible to avoid having th

[libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-11 Thread Laine Stump
If you define a libvirt virtual network with one or more IP addresses, it starts up an instance of dnsmasq. It's always been possible to avoid dnsmasq's dhcp server (simply don't include a element), but until now it wasn't possible to avoid having the DNS server listening; even if the network has