Re: [libvirt] [PATCH 2/3] qemu: Format rom.enabled attribute for PCI devices

2018-04-23 Thread Andrea Bolognani
On Mon, 2018-04-23 at 08:58 +0200, Peter Krempa wrote: > The test case will need to be added separately anyways. Here it is: https://www.redhat.com/archives/libvir-list/2018-April/msg02122.html -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 2/3] qemu: Format rom.enabled attribute for PCI devices

2018-04-23 Thread Peter Krempa
On Fri, Apr 20, 2018 at 17:44:30 +0200, Andrea Bolognani wrote: > The attribute can be used to disable ROM loading completely > for a device. You could mention that this is necessary because even if you turn the ROM BAR off, some firmware might still load it. > > Resolves: https://bugzilla.redha

[libvirt] [PATCH 2/3] qemu: Format rom.enabled attribute for PCI devices

2018-04-20 Thread Andrea Bolognani
The attribute can be used to disable ROM loading completely for a device. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1425058 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 13 ++-- tests/qemuxml2argvdata/pci-rom-disabled.args | 26