Re: [libvirt] [PATCH 2/3] qemu: don't use vmdef without domain lock

2016-12-09 Thread John Ferlan
On 12/09/2016 03:37 AM, Nikolay Shirokovskiy wrote: > > > On 08.12.2016 19:40, John Ferlan wrote: >> >> >> On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: >>> Current call to qemuAgentGetFSInfo in qemuDomainGetFSInfo is >>> unsafe. Domain lock is dropped and we use vm->def. To fix that >>>

Re: [libvirt] [PATCH 2/3] qemu: don't use vmdef without domain lock

2016-12-09 Thread Nikolay Shirokovskiy
On 08.12.2016 19:40, John Ferlan wrote: > > > On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: >> Current call to qemuAgentGetFSInfo in qemuDomainGetFSInfo is >> unsafe. Domain lock is dropped and we use vm->def. To fix that >> let's fill in intermediate qemuAgentFsInfo structure in >> qemuA

Re: [libvirt] [PATCH 2/3] qemu: don't use vmdef without domain lock

2016-12-08 Thread John Ferlan
On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: > Current call to qemuAgentGetFSInfo in qemuDomainGetFSInfo is > unsafe. Domain lock is dropped and we use vm->def. To fix that > let's fill in intermediate qemuAgentFsInfo structure in > qemuAgentGetFSInfo and use vm->def to convert result late

[libvirt] [PATCH 2/3] qemu: don't use vmdef without domain lock

2016-11-24 Thread Nikolay Shirokovskiy
Current call to qemuAgentGetFSInfo in qemuDomainGetFSInfo is unsafe. Domain lock is dropped and we use vm->def. To fix that let's fill in intermediate qemuAgentFsInfo structure in qemuAgentGetFSInfo and use vm->def to convert result later when lock is hold. --- src/qemu/qemu_agent.c