Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Laine Stump
On 08/25/2016 04:55 AM, Sascha Silbe wrote: Dear Laine, Laine Stump writes: The linkstate setting of an is only meant to change the online status reported to the guest system by the emulated network device driver in qemu, but when support for auto-creating tap devices for

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Vasiliy Tolstov
2016-08-25 8:57 GMT+03:00 Laine Stump : > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, but when support for auto-creating tap devices > for was added in commit 9717d6, a

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Laine Stump
On 08/25/2016 03:49 PM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 21:38 пользователь "Laine Stump" > написал: > > On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 19:18 пользователь "Laine Stump"

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 21:38 пользователь "Laine Stump" написал: > > On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 19:18 пользователь "Laine Stump" написал: >> > >> > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> >> >> 25 Авг 2016 г. 12:34

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Laine Stump
On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 19:18 пользователь "Laine Stump" > написал: > > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 19:18 пользователь "Laine Stump" написал: > > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov написал: >> > >> > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал:

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Laine Stump
On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov > написал: > > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" > написал: > > > > The linkstate setting

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Laine Stump
On 08/25/2016 05:41 AM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 8:58 пользователь "Laine Stump" > написал: > > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov написал: > > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал: > > > > The linkstate setting of an is only meant to change the > > online status reported to the guest system by the emulated network > >

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал: > > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, I need to set host side status of interface. Without this live

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 Thread Sascha Silbe
Dear Laine, Laine Stump writes: > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, but when support for auto-creating tap devices > for was added in commit 9717d6, a chunk of

[libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-24 Thread Laine Stump
The linkstate setting of an is only meant to change the online status reported to the guest system by the emulated network device driver in qemu, but when support for auto-creating tap devices for was added in commit 9717d6, a chunk of code was also added to qemuDomainChangeNetLinkState() that