Re: [libvirt] [PATCH 2/3] util: Fix error path in virSCSIVHostOpenVhostSCSI

2017-12-13 Thread Eric Farman
On 12/12/2017 09:22 AM, John Ferlan wrote: We cannot be sure someone initialized the passed *vhostfd and we certainly don't want or need to be calling VIR_FORCE_CLOSE on what probably is -1. So let's just return -1 immediately. Signed-off-by: John Ferlan Reviewed-by: Eric Farman --- sr

[libvirt] [PATCH 2/3] util: Fix error path in virSCSIVHostOpenVhostSCSI

2017-12-12 Thread John Ferlan
We cannot be sure someone initialized the passed *vhostfd and we certainly don't want or need to be calling VIR_FORCE_CLOSE on what probably is -1. So let's just return -1 immediately. Signed-off-by: John Ferlan --- src/util/virscsivhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d