Re: [libvirt] [PATCH 2/3] virStorageFileResize: fallocate the whole capacity

2017-09-27 Thread Ján Tomko
On Tue, Sep 26, 2017 at 06:44:55PM -0400, John Ferlan wrote: On 09/25/2017 11:46 AM, Ján Tomko wrote: We have been trying to implement the ALLOCATE flag to mean Is this the colloquial "we"? ;-) We believe so. "the volume should be fully allocated after the resize". commit id 'aa2a4cff

Re: [libvirt] [PATCH 2/3] virStorageFileResize: fallocate the whole capacity

2017-09-26 Thread John Ferlan
On 09/25/2017 11:46 AM, Ján Tomko wrote: > We have been trying to implement the ALLOCATE flag to mean Is this the colloquial "we"? ;-) > "the volume should be fully allocated after the resize". commit id 'aa2a4cff' added support for ALLOCATE, but it seems that code was wrong, then? The docs a

[libvirt] [PATCH 2/3] virStorageFileResize: fallocate the whole capacity

2017-09-25 Thread Ján Tomko
We have been trying to implement the ALLOCATE flag to mean "the volume should be fully allocated after the resize". Since commit b0579ed9 we do not allocate from the existing capacity, but from the existing allocation value. However this value is a total of all the allocated bytes, not an offset.