Re: [libvirt] [PATCH 2/3] virnetdev: Message in virNetDevSendEthtoolIoctl rather than caller.

2015-11-06 Thread Ján Tomko
On Wed, Nov 04, 2015 at 10:18:27AM -0500, John Ferlan wrote: > > > On 11/04/2015 04:39 AM, Ján Tomko wrote: > > On Tue, Nov 03, 2015 at 07:18:10PM -0500, John Ferlan wrote: > >> Since virNetDevSetupControl can generate a virReportSystemError, rather > >> than message in the caller for any errors.

Re: [libvirt] [PATCH 2/3] virnetdev: Message in virNetDevSendEthtoolIoctl rather than caller.

2015-11-04 Thread John Ferlan
On 11/04/2015 04:39 AM, Ján Tomko wrote: > On Tue, Nov 03, 2015 at 07:18:10PM -0500, John Ferlan wrote: >> Since virNetDevSetupControl can generate a virReportSystemError, rather >> than message in the caller for any errors. Do all the messaging in the >> virNetDevSendEthtoolIoctl. >> >> This cha

Re: [libvirt] [PATCH 2/3] virnetdev: Message in virNetDevSendEthtoolIoctl rather than caller.

2015-11-04 Thread Ján Tomko
On Tue, Nov 03, 2015 at 07:18:10PM -0500, John Ferlan wrote: > Since virNetDevSetupControl can generate a virReportSystemError, rather > than message in the caller for any errors. Do all the messaging in the > virNetDevSendEthtoolIoctl. > > This change partially reverts commit id '6f2a0198' by mov

[libvirt] [PATCH 2/3] virnetdev: Message in virNetDevSendEthtoolIoctl rather than caller.

2015-11-03 Thread John Ferlan
Since virNetDevSetupControl can generate a virReportSystemError, rather than message in the caller for any errors. Do all the messaging in the virNetDevSendEthtoolIoctl. This change partially reverts commit id '6f2a0198' by moving the error message in the virNetDev[G]FeatureAvailable to where the