Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Michal Privoznik
On 09.02.2015 14:19, Ján Tomko wrote: On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Ján Tomko
On Mon, Feb 09, 2015 at 09:47:47AM -0500, Laine Stump wrote: On 02/09/2015 08:19 AM, Ján Tomko wrote: On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_*

Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Daniel P. Berrange
On Mon, Feb 09, 2015 at 04:02:04PM +0100, Ján Tomko wrote: On Mon, Feb 09, 2015 at 09:47:47AM -0500, Laine Stump wrote: On 02/09/2015 08:19 AM, Ján Tomko wrote: On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else

Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Laine Stump
On 02/09/2015 08:19 AM, Ján Tomko wrote: On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

[libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Michal Privoznik
Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-)

Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Ján Tomko
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain.c | 28

Re: [libvirt] [PATCH 2/3] virsh: Use VIR_ENUM* macros for vshCmdAttachInterface

2015-02-09 Thread Peter Krempa
On Mon, Feb 09, 2015 at 10:58:29 +0100, Michal Privoznik wrote: Instead of verbose string to enum conversion (if STREQ() else if STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain.c | 28