Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Andrea Bolognani
On Tue, 2017-02-14 at 16:59 +, Daniel P. Berrange wrote: > > [1] I know I did while trying to figure this bug out ;) >  > If we disabled namespace support when libacl is missing at > build time you would have noticed quite quickly that you > weren't using namespaces. Not sure how quickly

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 05:47:27PM +0100, Andrea Bolognani wrote: > On Tue, 2017-02-14 at 16:20 +, Daniel P. Berrange wrote: > > > On the other hand, we really only care about having the ACL > > > APIs when we are isolating QEMU, which only happens of Linux > > > due to the namespaces

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Andrea Bolognani
On Tue, 2017-02-14 at 16:20 +, Daniel P. Berrange wrote: > > On the other hand, we really only care about having the ACL > > APIs when we are isolating QEMU, which only happens of Linux > > due to the namespaces requirement... So maybe we could have > > it as a strict requirement on Linux

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 05:14:33PM +0100, Andrea Bolognani wrote: > On Tue, 2017-02-14 at 16:00 +, Daniel P. Berrange wrote: > > Your platform has libacl available so it is not difficult to fix that > > by building with libacl support. We print out the configure summary > > precisely so users

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Andrea Bolognani
On Tue, 2017-02-14 at 16:00 +, Daniel P. Berrange wrote: > Your platform has libacl available so it is not difficult to fix that > by building with libacl support. We print out the configure summary > precisely so users can see if there's any libraries they forgot to > install which might be

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 04:55:05PM +0100, Michal Privoznik wrote: > On 02/14/2017 04:40 PM, Daniel P. Berrange wrote: > > On Tue, Feb 14, 2017 at 04:33:09PM +0100, Andrea Bolognani wrote: > >> When we're building a private /dev for the isolated QEMU > >> process, we want to be able to replicate

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Michal Privoznik
On 02/14/2017 04:40 PM, Daniel P. Berrange wrote: > On Tue, Feb 14, 2017 at 04:33:09PM +0100, Andrea Bolognani wrote: >> When we're building a private /dev for the isolated QEMU >> process, we want to be able to replicate the contents of >> the original /dev as closely as possible, including ACLs.

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 04:33:09PM +0100, Andrea Bolognani wrote: > When we're building a private /dev for the isolated QEMU > process, we want to be able to replicate the contents of > the original /dev as closely as possible, including ACLs. > > To ensure that's always possible, make ACL

[libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Andrea Bolognani
When we're building a private /dev for the isolated QEMU process, we want to be able to replicate the contents of the original /dev as closely as possible, including ACLs. To ensure that's always possible, make ACL support mandatory when the QEMU driver is enabled. Resolves: