Re: [libvirt] [PATCH 2/4] nwfilter: Fix potential locking problems on ObjLoad failure

2016-04-29 Thread John Ferlan
On 04/24/2016 07:22 PM, Cole Robinson wrote: > In virNWFilterObjLoad we can still fail after virNWFilterObjAssignDef, > but we don't unlock and free the created virNWFilterObjPtr in the > cleanup path. > > The bit we are trying to do after AssignDef is just STRDUP in the > configFile path.

[libvirt] [PATCH 2/4] nwfilter: Fix potential locking problems on ObjLoad failure

2016-04-24 Thread Cole Robinson
In virNWFilterObjLoad we can still fail after virNWFilterObjAssignDef, but we don't unlock and free the created virNWFilterObjPtr in the cleanup path. The bit we are trying to do after AssignDef is just STRDUP in the configFile path. However caching the configFile in the NWFilterObj is largely