Re: [libvirt] [PATCH 2/5] qemu: only check for PIIX3-specific device addrs on pc-* machinetypes

2013-07-24 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 06:18:14PM -0400, Laine Stump wrote: On 07/23/2013 11:24 AM, Daniel P. Berrange wrote: I'm thinking that it would probably be better to move all the re-indented code out into a qemuValidateDevicePCISlotsPIIX3() and just call that function from

Re: [libvirt] [PATCH 2/5] qemu: only check for PIIX3-specific device addrs on pc-* machinetypes

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 10:44:52AM -0400, Laine Stump wrote: The implicit IDE, USB, and video controllers provided by the PIIX3 chipset in the pc-* machinetypes are not present on other machinetypes, so we shouldn't be doing the special checking for them. The diffs for this patch look hairy,

Re: [libvirt] [PATCH 2/5] qemu: only check for PIIX3-specific device addrs on pc-* machinetypes

2013-07-23 Thread Laine Stump
On 07/23/2013 11:24 AM, Daniel P. Berrange wrote: I'm thinking that it would probably be better to move all the re-indented code out into a qemuValidateDevicePCISlotsPIIX3() and just call that function from qemuAssignDevicePCISlots(). That way if we need to add more validation for other

Re: [libvirt] [PATCH 2/5] qemu: only check for PIIX3-specific device addrs on pc-* machinetypes

2013-07-23 Thread Paolo Bonzini
Il 24/07/2013 00:18, Laine Stump ha scritto: On Tue, Jul 23, 2013 at 10:44:52AM -0400, Laine Stump wrote: (Note that, according to the qemuxml2argv-pseries-usb-multi test, ppc pseries machines also have a PIIX3 chip (since that test file adds a piix3-uhci usb controller). I don't know if