Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

2016-01-11 Thread Christian Benvenuti (benve)
> -Original Message- > From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] > On > Behalf Of Michal Privoznik > Sent: Monday, December 21, 2015 11:56 PM > To: Laine Stump; libvir-list@redhat.com > Cc: stef...@us.ibm.com > Subject: Re: [libvirt] [PATCH 2/5] util:

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

2016-01-11 Thread Laine Stump
On 01/11/2016 04:50 PM, Christian Benvenuti (benve) wrote: -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Michal Privoznik Sent: Monday, December 21, 2015 11:56 PM To: Laine Stump; libvir-list@redhat.com Cc: stef...@us.ibm.com

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

2015-12-21 Thread Stefan Berger
Laine Stump wrote on 12/21/2015 12:17:54 PM: > > This does cause a difference in behavior, so I want confirmation from > Cisco and IBM that this behavior change is desired (or at least not > *un*desired) - rather than returning with status unchanged (and thus > always 0, aka

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

2015-12-21 Thread Michal Privoznik
On 21.12.2015 18:17, Laine Stump wrote: > virNetDevVPortProfileGetStatus() would log the following error: > >Could not find netlink response with expected parameters > > anytime a port profile DISASSOCIATE operation was done for 802.1Qbh, > even though the disassociate had been successfully

[libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

2015-12-21 Thread Laine Stump
virNetDevVPortProfileGetStatus() would log the following error: Could not find netlink response with expected parameters anytime a port profile DISASSOCIATE operation was done for 802.1Qbh, even though the disassociate had been successfully completely. Then, due to the fortunate coincidence