Re: [libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

2018-01-08 Thread Pino Toscano
On Thursday, 4 January 2018 16:27:45 CET Jiri Denemark wrote: > It's not pointless. It makes the log useful without having to look at > /usr/include/asm-generic/errno-base.h. And it will only be done once in > libvirtd lifetime so it's not really wasting CPU cycles or something. Theoretically you

Re: [libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

2018-01-04 Thread Ján Tomko
On Thu, Jan 04, 2018 at 04:27:45PM +0100, Jiri Denemark wrote: On Thu, Jan 04, 2018 at 16:15:46 +0100, Peter Krempa wrote: On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote: > +char ebuf[1024]; > +VIR_DEBUG("Failed to read microcode version from %s: %s", > +

Re: [libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

2018-01-04 Thread Jiri Denemark
On Thu, Jan 04, 2018 at 16:15:46 +0100, Peter Krempa wrote: > On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote: > > From: Paolo Bonzini > > > > This new API reads host's CPU microcode version from /proc/cpuinfo. > > > > Unfortunately, there is no other way of

Re: [libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

2018-01-04 Thread Peter Krempa
On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote: > From: Paolo Bonzini > > This new API reads host's CPU microcode version from /proc/cpuinfo. > > Unfortunately, there is no other way of reading microcode version which > would be usable from both system and

[libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

2018-01-04 Thread Jiri Denemark
From: Paolo Bonzini This new API reads host's CPU microcode version from /proc/cpuinfo. Unfortunately, there is no other way of reading microcode version which would be usable from both system and session daemon. Signed-off-by: Paolo Bonzini