Re: [libvirt] [PATCH 2/5] virerror: Fix incorrect use of RaiseErrorFull

2014-05-05 Thread Eric Blake
On 05/03/2014 01:59 PM, Cole Robinson wrote: > RaiseErrorFull does not prepend the static error code string (like > INVALID_ARG yields "invalid arg: %(msg)s"). We should be using > ReportErrorHelper. I'd get Dan's opinion on this one, since he first introduced the macros in commit d91f3ef and may

Re: [libvirt] [PATCH 2/5] virerror: Fix incorrect use of RaiseErrorFull

2014-05-04 Thread Guido Günther
On Sat, May 03, 2014 at 03:59:39PM -0400, Cole Robinson wrote: > RaiseErrorFull does not prepend the static error code string (like > INVALID_ARG yields "invalid arg: %(msg)s"). We should be using > ReportErrorHelper. > > The generated error objects are slightly different, by not storing the > inv

[libvirt] [PATCH 2/5] virerror: Fix incorrect use of RaiseErrorFull

2014-05-03 Thread Cole Robinson
RaiseErrorFull does not prepend the static error code string (like INVALID_ARG yields "invalid arg: %(msg)s"). We should be using ReportErrorHelper. The generated error objects are slightly different, by not storing the invalid argument name in err->str2. However those fields aren't used anywhere