Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-21 Thread Eric Blake
On 03/21/2014 04:51 AM, Daniel P. Berrange wrote: >> >> I've been going by the general rule of thumb that if emacs reindents >> something, then my style wasn't consistent with the bulk of the code; >> but I agree that HACKING doesn't actually mention this, and not everyone >> uses emacs. > > Yep,

Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-21 Thread Jiri Denemark
On Fri, Mar 21, 2014 at 10:51:58 +, Daniel Berrange wrote: > On Thu, Mar 20, 2014 at 11:39:18AM -0600, Eric Blake wrote: > > On 03/20/2014 11:28 AM, Daniel P. Berrange wrote: > > > On Thu, Mar 20, 2014 at 06:16:08PM +0100, Michal Privoznik wrote: > > >> On 20.03.2014 13:28, Daniel P. Berrange w

Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-21 Thread Daniel P. Berrange
On Thu, Mar 20, 2014 at 11:39:18AM -0600, Eric Blake wrote: > On 03/20/2014 11:28 AM, Daniel P. Berrange wrote: > > On Thu, Mar 20, 2014 at 06:16:08PM +0100, Michal Privoznik wrote: > >> On 20.03.2014 13:28, Daniel P. Berrange wrote: > >>> The test suites often have to create DBus method reply mess

Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-20 Thread Eric Blake
On 03/20/2014 11:28 AM, Daniel P. Berrange wrote: > On Thu, Mar 20, 2014 at 06:16:08PM +0100, Michal Privoznik wrote: >> On 20.03.2014 13:28, Daniel P. Berrange wrote: >>> The test suites often have to create DBus method reply messages >>> with payloads. Create two helpers for simplifying the proce

Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-20 Thread Daniel P. Berrange
On Thu, Mar 20, 2014 at 06:16:08PM +0100, Michal Privoznik wrote: > On 20.03.2014 13:28, Daniel P. Berrange wrote: > >The test suites often have to create DBus method reply messages > >with payloads. Create two helpers for simplifying the process > >of creating replies with payloads. > > > >Signed-

Re: [libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-20 Thread Michal Privoznik
On 20.03.2014 13:28, Daniel P. Berrange wrote: The test suites often have to create DBus method reply messages with payloads. Create two helpers for simplifying the process of creating replies with payloads. Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms | 2 ++ src/util/vir

[libvirt] [PATCH 2/6] Add DBus helper methods for creating reply messages

2014-03-20 Thread Daniel P. Berrange
The test suites often have to create DBus method reply messages with payloads. Create two helpers for simplifying the process of creating replies with payloads. Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms | 2 ++ src/util/virdbus.c | 60 +