Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: New APIs are added allowing streaming of content to/from storage volumes. * include/libvirt/libvirt.h.in: Add virStorageVolUpload and virStorageVolDownload APIs * src/driver.h, src/libvirt.c, src/libvirt_public.syms: Stub code for new

[libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-23 Thread Daniel P. Berrange
New APIs are added allowing streaming of content to/from storage volumes. * include/libvirt/libvirt.h.in: Add virStorageVolUpload and virStorageVolDownload APIs * src/driver.h, src/libvirt.c, src/libvirt_public.syms: Stub code for new APIs * src/storage/storage_driver.c,

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 03:04:39PM -0600, Eric Blake wrote: On 03/18/2011 10:36 AM, Daniel P. Berrange wrote: New APIs are added allowing streaming of content to/from storage volumes. A new API for creating volumes is also added allowing the content to be provided immediately at time of

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Eric Blake
On 03/22/2011 05:45 AM, Daniel P. Berrange wrote: What happens if the stream hits EOF before all data read from the volume has been written to the stream? Should the API support a way to tell how many bytes were successfully downloaded in the case of a short stream? That is, instead of

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Daniel P. Berrange
On Tue, Mar 22, 2011 at 08:22:05AM -0600, Eric Blake wrote: On 03/22/2011 05:45 AM, Daniel P. Berrange wrote: What happens if the stream hits EOF before all data read from the volume has been written to the stream? Should the API support a way to tell how many bytes were successfully

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-21 Thread Eric Blake
On 03/18/2011 10:36 AM, Daniel P. Berrange wrote: New APIs are added allowing streaming of content to/from storage volumes. A new API for creating volumes is also added allowing the content to be provided immediately at time of creation Delete this last sentence; it's stale information from